Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add macvtap-cni jobs #308

Merged
merged 1 commit into from
Feb 7, 2020
Merged

add macvtap-cni jobs #308

merged 1 commit into from
Feb 7, 2020
+110 −0

Conversation

phoracek
Copy link
Member

@phoracek phoracek commented Jan 18, 2020 •
edited
Loading

Signed-off-by: Petr Horacek [email protected]

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 18, 2020
@phoracek phoracek mentioned this pull request Feb 4, 2020
Merged
@maiqueb
Copy link
Contributor

maiqueb commented Feb 4, 2020

@phoracek anyclue on how to get past the prow config error ?

@phoracek
Copy link
Member Author

phoracek commented Feb 4, 2020

I did not get a chance to debug it. Lemme finish a review of this PR and then get back to the prow.

@phoracek phoracek changed the title WIP add macvtap-cni jobs add macvtap-cni jobs Feb 7, 2020
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2020
@phoracek phoracek force-pushed the macvtap-cni branch 3 times, most recently from f5b12ff to fd55b0e Compare February 7, 2020 12:16
@phoracek
add macvtap-cni jobs
b61707a 
Signed-off-by: Petr Horacek <[email protected]>
@qinqon
Copy link
Contributor

qinqon commented Feb 7, 2020

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2020
@kubevirt-bot kubevirt-bot merged commit 1d97cf9 into kubevirt:master Feb 7, 2020
@kubevirt-bot
Copy link
Contributor

@phoracek: Updated the following 3 configmaps:

  • config configmap in namespace kubevirt-prow at cluster default using the following files:
    • key config.yaml using file github/ci/prow/files/config.yaml
  • job-config configmap in namespace kubevirt-prow at cluster default using the following files:
    • key macvtap-cni-postsubmits.yaml using file github/ci/prow/files/jobs/macvtap-cni/macvtap-cni-postsubmits.yaml
    • key macvtap-cni-presubmits.yaml using file github/ci/prow/files/jobs/macvtap-cni/macvtap-cni-presubmits.yaml
  • plugins configmap in namespace kubevirt-prow at cluster default using the following files:
    • key plugins.yaml using file github/ci/prow/files/plugins.yaml

In response to this:

Signed-off-by: Petr Horacek [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@booxter booxter Awaiting requested review from booxter

@gbenhaim gbenhaim Awaiting requested review from gbenhaim

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phoracek @maiqueb @qinqon @kubevirt-bot